Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to inject properties into alert messages #26

Closed
whoiskevinrich opened this issue Jun 14, 2018 · 6 comments
Closed

Add ability to inject properties into alert messages #26

whoiskevinrich opened this issue Jun 14, 2018 · 6 comments

Comments

@whoiskevinrich
Copy link

Allow the insertion of seq properties into messages parsed by alerts

@rocklan
Copy link

rocklan commented Jul 31, 2018

The problem is that alerts are an aggregate of multiple messages, so how would you choose which properties to include?

@whoiskevinrich
Copy link
Author

The alert is fired from a query. By default, the alert trigger is something like count > 5.

image

image

However, alerting supports customizing the query to fire based on multiple select statements:
image

To which the Alerts system has access to:
image

Now the example above is contrived, and I would probably never do anything useful with an Applications Property, but sometimes I'm tracking to make sure a signal property is staying within bounds, and I'd like to know what the Min and Max value of a timeslice is, base my alarm on that, and do so without creating separate alarms.

Basically, I'm not looking for the properties of the signals, but rather the properties on the dashboard query's "Select" statement

@nblumhardt
Copy link
Collaborator

These are provided to the app in a property called Results, which is more like a rowset than easily-readable property values, unfortunately.

It's used in the email app's default template here: https://github.com/datalust/seq-apps/blob/master/src/Seq.App.EmailPlus/Resources/DefaultBodyTemplate.html#L84

This currently only shows group headings rather than column headings :-/ but does include the data:

image

Not sure what kinds of display options Slack provides, but we might be able to format this up nicely as a table with a bit of tinkering...

@dazinator
Copy link

Also really would like this.

I wonder if one possibility would be to "Group By" for example "Tenant Name"
Then allow the GroupBy argument to be accessible as a property in the template?

For example if we are grouping by TenantName, then it would be good if we could somehow use the group's value in the template e.g "Customer A"

Image

@whoiskevinrich
Copy link
Author

I'm closing the issue; it's 7 years old and I'm not concerned about it anymore :D

@nblumhardt
Copy link
Collaborator

@dazinator this might also fall out of #68, if we were to do that - group names are in the Results object and expressions can be used to pull them out. It's a little trickier because one alert might be triggered by multiple groups, but still seems to be roughly aligned with that direction...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants