Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normDiv in pyCGM_Single/pyCGM.py #31

Open
thepeytongreen opened this issue Oct 21, 2020 · 1 comment
Open

normDiv in pyCGM_Single/pyCGM.py #31

thepeytongreen opened this issue Oct 21, 2020 · 1 comment
Assignees
@thepeytongreen
Labels
bug-light A bug that hasn't caused problems but could later

Comments

@thepeytongreen
Copy link
Contributor

thepeytongreen commented Oct 21, 2020 •
edited by cadop
Loading

Function normDiv in pyCGM_single/pyCGM.py should be calculation the normalization, vec, and then dividing every x, y, and z by vec. Instead it divides each x, y, z by vec twice. I believe just removing the following line,

pyCGM/pyCGM_Single/pyCGM.py

Line 2256 in 360fb86

def normDiv(v):
, should fix it:
v = [v[0]/vec,v[1]/vec,v[2]/vec]
@cadop
Copy link
Owner

cadop commented Oct 21, 2020

This seems to not be used anywhere and is legacy, once unittests are done please delete it.

@cadop cadop added trivial simple issue of not much concern bug-light A bug that hasn't caused problems but could later and removed trivial simple issue of not much concern labels Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thepeytongreen thepeytongreen

Labels
bug-light A bug that hasn't caused problems but could later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cadop @thepeytongreen