Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve alt text for logos on About Us page #29

Closed
carrythebanner opened this issue Nov 8, 2019 · 0 comments · Fixed by #36
Closed

Improve alt text for logos on About Us page #29

carrythebanner opened this issue Nov 8, 2019 · 0 comments · Fixed by #36

Comments

@carrythebanner
Copy link
Contributor

On the "About us" page (http://calagator.org/about), the "Attributions" section credits a number of logo images. Each image has alt text, but currently it's a mix of a useful label and some random letters and numbers. For example:
<img src="/assets/tag_icons/ruby-6cb4bb736e6c4cb0000f6e4d6254e13d9088263198adc4a1fd0676f8a2f84c34.png" alt="Ruby 6cb4bb736e6c4cb0000f6e4d6254e13d9088263198adc4a1fd0676f8a2f84c34">

Alt text should be human-readable and contextually appropriate. Images will be identified as such by screen readers, so typically alt text should not include the word "image." But in this case since logos are specifically being identified, I'd recommend "Ruby logo" (vs. just "Ruby"), as in:
<%= image_tag "tag_icons/ruby.png" alt: "Ruby logo" %>

@reidab reidab closed this as completed in #36 Dec 1, 2019
reidab added a commit that referenced this issue Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant