Add landmarks to improve screen reader navigation options #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrythebanner
changed the title
|
I looked through the test coverage report, but I couldn't really make sense of it. I'd be happy to take a crack at adding some tests if anyone can point me in the right direction for where they need to be adjusted. |
reidab
force-pushed
the
landmarks
branch
2 times, most recently
from
d7994d3 to
b741f7f
Compare
reidab
force-pushed
the
no-checks-on-forks
branch
from
e2d037a to
ab3d0e8
Compare
reidab
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds landmarks to improve navigation options when using a screen reader or other landmark-aware tools:
headerelement is used for top matter which appears on every page appears. Inside of that:navelements for primary navigation and sub navigation for Events/Venues; eachnavelement has anaria-labelto differentiate them.role="search"added to a wrapper around the global search controlsmainelement used for primary page contentfooterelement used for version infoFixes calagator/calagator.org#33.