chore: use build-android/ios commands in added scripts inside example app
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
force-pushed
the
szymonrybczak/chore/use-rnc-cli-in-added-scripts
branch
from
c269673
to
ad0938b
Compare
satya164
approved these changes
Jul 3, 2024
packages/create-react-native-library/src/utils/generateExampleApp.ts
Outdated
Show resolved
Hide resolved
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With fairly new commands
build-android/iosadded inside React Native Community CLI we can replace manually calling./gradlewandxcodebuildinsidebuild:androidandbuild:iosscripts.Test plan
create-react-native-librarybuild:androidandbuild:iosscripts should have the same result as before ✅