Uses the corresponding react-native init version #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@satya164 let me know if you need anything else from me! This should fix using this module with the new nightly versions of RN :) |
|
I'll check locally and release tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #580
Summary
Uses the corresponding version of react-native init as specified by the "--version" flag. This allows the module to be used on RNW versions other than "latest" since latest isn't always compatible with every version and a new version may introduce breaking changes.
Test plan
Actually wasn't able to test this module locally, the instructions failed for me :( but tested
npx --yes [email protected] init testcli --directory examples --version 0.75.0-rc.2 --skip-install --npmto make sure it works as intended.