Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init command in generateTestApp method to use new @react-native-community/template package #589

Closed
wants to merge 1 commit into from

Conversation

Yajur-Grover
Copy link
Contributor

@Yajur-Grover Yajur-Grover commented Jul 15, 2024

Summary

This PR edits the init command to use the new template at @react-native-community/template. Currently, it is set to use the next version, as there is a big discrepancy between the nightly build versions available on the react-native package and new @react-native-community/template package.

This PR adds a job that will publish a nightly build to the @react-native-community/template package every time a new react-native package is published. Once the react-native-windows repo is integrated up to the same date, we will revert the 'next' to 'reactNativeVersion'. This pending change is tracked in the following issue: microsoft/react-native-windows#13446

Test plan

  1. Change the create-react-native-library.cmd line 3 to the following:
    node "%~dp0\create-react-native-library" %* --slug testcli --description testcli --author-name "React-Native-Windows Bot" --author-email [email protected] --author-url http://example.com/ --repo-url http://example.com/ --languages java-objc --type module-new --react-native-version 0.75.0-nightly-20240618-5df5ed1a8 --example vanilla testcli
  2. Run yarn watch
  3. Run packages/create-react-native-library/bin/create-react-native-library

Copy link
Contributor

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what's the issue here - when you pass --react-native-version next to CRNL it should use react-native@next which currently contains a logic for downloading template from react-native-community/template.

@Yajur-Grover
Copy link
Contributor Author

Yes I applied a more approriate fix to our CLI test in our React Native Windows repo - this change is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants