Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix examples in build docs #602

Closed
wants to merge 1 commit into from
Closed

fix examples in build docs #602

wants to merge 1 commit into from

Conversation

zhirzh
Copy link

@zhirzh zhirzh commented Jul 29, 2024

Summary

in build docs page, move examples for "copyFlow" and "sourceMaps" options to correct sections

Screenshot 2024-07-29 at 10 35 17 PM

Test plan

None

@satya164
Copy link
Member

Thanks for the PR. However the examples were meant to be for the whole target and not a specific option. This change isn't correct since now there's an example for module target under commonjs section.

@zhirzh zhirzh closed this Jul 30, 2024
@zhirzh zhirzh deleted the patch-1 branch July 30, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants