Hanging on invalid default recipe

[uncenter]

I mistakenly wrote this in my justfile:

_default:
  @just --list-submodules

Which causes just to hang when invoked. This seems to be because just --list-submodules is invalid unless used alongside --list - just --list --list-submodules works as expected (hanging on that default recipe might also be some kind of bug?).

[uncenter]

Ah, I guess this is because just uses some flags as commands (presumably to avoid conflicting with task names), and --list-submodules is in the "options" list rather than the "commands" list.

[uncenter]

I'll repurpose this for that hanging bug I noticed. If you add that default recipe, and invoke just, I am seeing no output for a few seconds before just finally quits and logs the following (infinitely? seems to just keep going on forever until I quit the process).

error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1
error: Recipe `_default` failed on line 4 with exit code 1

[laniakea64]

just --list-submodules apparently just runs the default recipe, which in this case is to run just --list-submodules, which again runs the default recipe, which in this case is to run just --list-submodules,...

Seems the actual issue is that --list-submodules being a silent no-op in the absence of -l is weird and unexpected?

[uncenter]

Ah yep that sounds like the right diagnosis. I would expect https://docs.rs/clap/latest/clap/struct.Arg.html#method.requires to be set for

just/src/config.rs

Lines 286 to 293 in 49f282f

	.arg(
	Arg::new(arg::LIST_SUBMODULES)
	.long("list-submodules")
	.env("JUST_LIST_SUBMODULES")
	.help("List recipes in submodules")
	.action(ArgAction::SetTrue)
	.env("JUST_LIST_SUBMODULES"),
	)

so that there is some sort of error messaging.

[casey]

Seems reasonable, especially since --list-submodules is so easy to confuse for a command. Fixed in #2622.