Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request Update] twemoji #475

Closed
RikoDEV opened this issue Oct 24, 2020 · 6 comments · Fixed by #496 · May be fixed by #1946
Closed

[Request Update] twemoji #475

RikoDEV opened this issue Oct 24, 2020 · 6 comments · Fixed by #496 · May be fixed by #1946
Assignees
@MattIPv4
Labels
📦 Update Request Request for an existing library on cdnjs to be updated

Comments

@RikoDEV
Copy link

RikoDEV commented Oct 24, 2020

Library name: twemoji

Library JSON file link: https://github.com/cdnjs/packages/blob/master/packages/t/twemoji.json

Library source (NPM package or Git repo): https://github.com/twitter/twemoji

Files to include: 13.0.1
@RikoDEV RikoDEV added the 📦 Update Request Request for an existing library on cdnjs to be updated label Oct 24, 2020
@MattIPv4
Copy link
Member

MattIPv4 commented Nov 2, 2020

So it looks like the git repo no longer has the scripts in it, and the NPM package no longer has the assets in it.

Do you agree that it'd be fine to just host the assets from https://github.com/twitter/twemoji/tree/master/assets ?

@MattIPv4 MattIPv4 self-assigned this Nov 8, 2020
@MattIPv4 MattIPv4 mentioned this issue Nov 8, 2020
Merged
@lovelxc
Copy link

lovelxc commented Jan 24, 2025

So it looks like the git repo no longer has the scripts in it, and the NPM package no longer has the assets in it.

Do you agree that it'd be fine to just host the assets from https://github.com/twitter/twemoji/tree/master/assets ?

Can u merge the js scripts on https://www.npmjs.com/package/twemoji (tag 14.0.2)

@MattIPv4
Copy link
Member

No, we cannot combine multiple sources into a single package.

@lovelxc
Copy link

lovelxc commented Jan 24, 2025

No, we cannot combine multiple sources into a single package.

What about create a new package for https://www.npmjs.com/package/twemoji such as 'twemoji-js'?

@MattIPv4
Copy link
Member

Sure, feel free to open a PR to add it.

@lovelxc
Copy link

lovelxc commented Jan 24, 2025

Sure, feel free to open a PR to add it.

I will try to do this.

@lovelxc lovelxc mentioned this issue Jan 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattIPv4 MattIPv4

Labels
📦 Update Request Request for an existing library on cdnjs to be updated
Projects
None yet
Milestone
No milestone
3 participants
@MattIPv4 @RikoDEV @lovelxc