Add exception to get go-vuln passing #3516
Assignees
Labels
WS: Maintenance 🔧
includes bugs, refactors, flakes, and tech debt etc
Comments
evan-forbes
added
the
WS: Maintenance 🔧
|
Doesn't seem possible to ignore a particular vulerability per |
Merged
rootulp
added a commit
that referenced
this issue
Jun 5, 2024
Closes #3516 Opens #3530 This PR removes govulncheck from CI because govulncheck does not support ignoring a particular vulnerability. Since we're on ibc-go v6.2.x which has a vulnerability, CI will report a red X on all future PRs because govulncheck fails. We can re-enable govulncheck when it adds support for ignoring a particular vulnerability.
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this issue
Aug 1, 2024
Closes celestiaorg/celestia-app#3516 Opens celestiaorg/celestia-app#3530 This PR removes govulncheck from CI because govulncheck does not support ignoring a particular vulnerability. Since we're on ibc-go v6.2.x which has a vulnerability, CI will report a red X on all future PRs because govulncheck fails. We can re-enable govulncheck when it adds support for ignoring a particular vulnerability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There is rightfully a vuln in ibc v6.2, so the ci will fail. This vuln doesn't affect celestia-app since cosmwasm is not installed, therefore we can add an exception to avoid the red x in CI
Acceptance Criteria
The text was updated successfully, but these errors were encountered: