Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Digest to Hash #48

Open
cespare opened this issue Nov 20, 2020 · 2 comments
Open

Rename Digest to Hash #48

cespare opened this issue Nov 20, 2020 · 2 comments
Assignees
Milestone

Comments

@cespare
Copy link
Owner

cespare commented Nov 20, 2020

Digest is not a good name. Normally "digest" refers to the output of the hash function.

In v3 we could consider renaming it; perhaps to Hash.

Typical code probably doesn't refer to Digest by name and doesn't have to change:

d := xxhash.New()
... call d.Write() ...
x := d.Sum64()
@cespare cespare added this to the v3 milestone Nov 20, 2020
@cespare cespare self-assigned this Nov 20, 2020
@greatroar
Copy link
Contributor

Hash also refers the output of a hash function :)

@cespare
Copy link
Owner Author

cespare commented Nov 20, 2020

Yes, but it it is also the name of the type of function...as in hash function. (Plus this matches hash.Hash.)

Open to better suggestions though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants