Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum required CMake version #114

Open
scheibel opened this issue Feb 5, 2023 · 7 comments
Open

Upgrade minimum required CMake version #114

scheibel opened this issue Feb 5, 2023 · 7 comments

Comments

@scheibel
Copy link
Member

scheibel commented Feb 5, 2023

Time passed and we should discuss the currently minimum required version of cmake-init.
@Tachi107 argues that 3.5 is a feasible alternative (#112).

Maybe we can and should go even higher.
CMake has had a lot of interesting improvements in it's later versions, superseding some of our own implementations.

At least, we should get rid of the compatibility layer source code.

@sbusch42
Copy link
Member

sbusch42 commented Feb 5, 2023

I'm fine with updating. I'm not on track with new versions of cmake, but in general, I prefer supporting relatively current versions and not trying to keep compatibility with old versions too long. So, let's update :)

@Tachi107
Copy link

Tachi107 commented Feb 5, 2023 via email

@scheibel
Copy link
Member Author

scheibel commented Feb 13, 2023

A quick summary of available CMake versions by OS / distribution and distribution channel:

As far as I collected data, our main major platforms and major distribution channels allow for a CMake version of 3.15 or higher. If we ignore the out-of-date package in nuget, it's CMake 3.18 or higher.
And as @Tachi107 mentioned, there's always the possibility to grab a pre-built version of CMake or build it from source yourself (https://cmake.org/download/).

@aiyolo
Copy link

aiyolo commented May 19, 2023

I think we can create different branches for different CMake versions. This approach allows users to maintain separate code bases that are compatible with specific CMake versions. By doing so, users who require a lower CMake version can use the appropriate branch while others can work with the latest version.

@Tachi107
Copy link

Tachi107 commented May 19, 2023 via email

@Tachi107
Copy link

According to https://lists.debian.org/debian-devel/2023/06/msg00150.html, CMake 3.27 will begin issuing deprecation warning if projects declare a cmake_minimum_required() version lower than 3.5.

This is a clear indication from the CMake devs that yes, we should bump the minimum required version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants