fix: Dashboard app data injection #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @muhsin-k can you pls take a look at this PR? |
muhsin-k
changed the title
muhsin-k
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Dashboard App data injection
Description
Fixes Dashboard App data injection by enabling javascript in WebView and send the data after the webpage loading ends.
Fixes #906
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
You can host index.html from https://github.com/JaideepGuntupalli/chatwoot-sample-dashboard-app/tree/main locally and proxy using ngrok and add as dashboard app to any one of the account. You can open the same account on chatwoot mobile app and try to load this dashboard app. There is no json being sent earlier, but after this change we actually get the json
Checklist: