feat: remove live courses support #1271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strawHat121 is attempting to deploy a commit to the Chayn Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1177
What changes did you make and why did you make them?
Removed or simplified ternary conditions across CourseCard.tsx, CourseIntroduction.tsx, StoryblokCoursePage.tsx, StoryblokSessionPage.tsx whichever were dependent on coming soon or live now related variables.
Removed CourseStatusHeader.tsx and courseLiveStatus.ts as they are no longer required following the deprecation of the "Live courses" feature.
Deleted localization messages related to "live courses" across all languages, including of liveFrom, liveSoon, liveUntil and comingSoon.
Did you run tests? Share screenshot of results:
Yarn -
I also ran cypress tests and the only one that failed for me was related to CYPRESS_BADOO one because I haven't configured that one yet in the environment variables.
How did you find us? (GitHub, Google search, social media, etc.):
Through GitHub.