Properties for Checkstyle Problem doesn't show the Correct Group

[rnveach]

Identified when working on #451 ,

I added ImportControl to the project and new violations show up. When I go to the properties dialog for the new Checkstyle Problem, I am told "Group" is "Other" for the check.

However, Eclipse-CS' own configuration panel says it should be under "Imports". The only thing under "Other" is "Checker" and "TreeWalker".

I expected that we show the same group name on the properties dialog as our configuration dialog.

[rnveach]

eclipse-cs/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java

Lines 317 to 323 in dd602eb

	RuleMetadata metaData = MetadataFactory.getRuleMetadata(error.getSourceName());
	// create generic metadata if none can be found
	if (metaData == null) {
	Module module = new Module(error.getSourceName());
	metaData = MetadataFactory.createGenericMetadata(module);
	}

I find it interesting we look for the metadata and if it doesn't exist, we create fake metadata and put it under "Other". It seems odd we create a fake metadata and don't even pass it to MarkerPropertyPage to display on the dialog. It could just save a simple look up, and even still we should be able to operate without everything being faked into the metadata.

I haven't debugged to confirm, but it does look like this area is the issue. getSourceName is most likely the FQCN and metadata is looking based on the simple check name (IE: com.puppycrawl.tools.checkstyle.checks.imports.ImportControlCheck versus ImportControl).

[Bananeweizen]

I haven't debugged to confirm, but it does look like this area is the issue. getSourceName is most likely the FQCN and metadata is looking based on the simple check name (IE: com.puppycrawl.tools.checkstyle.checks.imports.ImportControlCheck versus ImportControl).

That sounds very similar to what I experienced here: #397 (comment), when I wrote that the metadata somehow changed over the runtime of the application.

[Bananeweizen]

duplicate of #397