You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pull request contains several commits.
on local history is linear, so patch using your last commit ONLY.
in Travis CI, all commits are combined as one merge commit that is applied over master HEAD (it is non configurable feature of Travis) to not execute CI on old code and clearly know result after merge.
We need to find a way to generate patch file in same way as it is done by Travis to show whole code change diff in Pull Request or last changes. As not all in world use Travis, all other CIs does not make merge commit.
Without this smart patch generation there is gap in Patch filter to let uses put meaningless commit on top to hide all violations from previous commits.
But in the same time it helps to bypass situations with avalanche of checkstyle violations (fix one violation, trigger changes in other lines, fixing them, another line affected, new violations, ......) and merge with failures in CI and have green build after merge.
The text was updated successfully, but these errors were encountered:
detected at checkstyle/eclipse-cs#350
Pull request contains several commits.
on local history is linear, so patch using your last commit ONLY.
in Travis CI, all commits are combined as one merge commit that is applied over master HEAD (it is non configurable feature of Travis) to not execute CI on old code and clearly know result after merge.
how to generate last commit file in maven:
https://github.com/checkstyle/eclipse-cs/blob/3522eb691c7c1ad230900c6c26754783121d5154/pom.xml#L118-L120
checkstyle config:
https://github.com/checkstyle/eclipse-cs/blob/2cb3fb24be136882706b2dd4edd75ed31f9d6dae/config/checkstyle_sevntu_checks.xml#L15-L24
We need to find a way to generate patch file in same way as it is done by Travis to show whole code change diff in Pull Request or last changes. As not all in world use Travis, all other CIs does not make merge commit.
Without this smart patch generation there is gap in Patch filter to let uses put meaningless commit on top to hide all violations from previous commits.
But in the same time it helps to bypass situations with avalanche of checkstyle violations (fix one violation, trigger changes in other lines, fixing them, another line affected, new violations, ......) and merge with failures in CI and have green build after merge.
The text was updated successfully, but these errors were encountered: