Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize test code for old metadata loading #323

Closed
romani opened this issue Aug 30, 2020 · 4 comments
Closed

optimize test code for old metadata loading #323

romani opened this issue Aug 30, 2020 · 4 comments

Comments

@romani
Copy link
Member

romani commented Aug 30, 2020

fix review comment - #318 (comment)
@romani romani changed the title optimize test code for old metadata loding optimize test code for old metadata loading Aug 30, 2020
@romani romani mentioned this issue Aug 30, 2020
Merged
@romani
Copy link
Member Author

romani commented Aug 30, 2020

@gaurabdg , please fix.

@muhlba91
Copy link
Contributor

muhlba91 commented Sep 1, 2020

see https://github.com/checkstyle/sonar-checkstyle/pull/318/files#r480861093

i believe #322 and #321 are of high importance and should be fixed now. next up probably #324 and this one can be looked at last.

@gaurabdg
Copy link
Contributor

gaurabdg commented Sep 1, 2020

#322 is solved by #325

@gaurabdg gaurabdg mentioned this issue Sep 1, 2020
Merged
@muhlba91
Copy link
Contributor

since we dropped the old mechanism, i believe this is not an issue anymore. closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@muhlba91 @romani @gaurabdg