Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFP - Kugou #653

Closed
4 tasks done
fox272 opened this issue Aug 14, 2019 · 5 comments
Closed
4 tasks done

RFP - Kugou #653

fox272 opened this issue Aug 14, 2019 · 5 comments

Comments

@fox272
Copy link

fox272 commented Aug 14, 2019

  • The package I am requesting does not already exist on https://chocolatey.org/packages;
  • There is no open issue for this package;
  • The issue title starts 'RFP - ';
  • The download URL is public and not locked behind a paywall / login;

Package Details

Software project URL : https://www.kugou.com/
Direct download URL for the software / installer : http://download.kugou.com/download/kugou_pc
Software summary / short description :
KuGou (Chinese: 酷狗音乐) is a Chinese music streaming and download service established in 2004 and owned by Tencent Music. It is the largest music streaming service in the world, with more than 450 million monthly active users.

Package Expectations

adding icons to the desktop

@fox272
Copy link
Author

fox272 commented Aug 14, 2019

thanks for your help

@chtof
Copy link

chtof commented Aug 15, 2019

Chocolatey package fails because Get-WebHeaders switch to HTTPS for download but the file can only been successfully downloaded in HTTP.
How to avoid to switch to HTTPS?

  • Invoke-WebRequest -Uri "http://download.kugou.com/download/kugou_pc" : It works as expected
  • Invoke-WebRequest -Uri "https://download.kugou.com/download/kugou_pc" : HTTP Status code 200 but It doesn't download the file.
  • cinst kugou -dv -s "."
    (...)
    WARNING: Url has SSL/TLS available, switching to HTTPS for download
    Running Get-WebFileName -url 'https://download.kugou.com/download/kugou_pc' -defaultName 'kugouInstall.exe'
    Using response url to determine file name. 'https://download.kugou.com/download/kugou_pc'
    File name determined from url is 'kugou_pc'
    Running Get-WebHeaders -url 'https://download.kugou.com/download/kugou_pc' -ErrorAction 'Stop'
    Setting the UserAgent to 'chocolatey command line'
    Request Headers:
    'Accept':'/'
    'User-Agent':'chocolatey command line'
    Response Headers:
    'Connection':'keep-alive'
    'Keep-Alive':'timeout=20'
    'Content-Length':'0'
    'Content-Type':'text/plain'
    'Date':'Thu, 15 Aug 2019 19:44:15 GMT'
    'Server':'KugouCDN'

@AdmiringWorm
Copy link
Member

Sounds like the same issue we have with the nlite package.
Only way currently around it is to embedd the software (if the licensing and size allows it).

Issue related: chocolatey/choco#1221

I will mark this issue as blocked for now.

@pauby
Copy link
Member

pauby commented Feb 7, 2020

@chtof Has there been any progress on this or are you waiting for chocolatey/choco#1221 ?

@chtof
Copy link

chtof commented Feb 7, 2020

I didn't find any license to allow to embed the package. Close as something like can't fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants