Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Passthru parameter on Get-WebFile PowerShell helper #2640

Open
AdmiringWorm opened this issue Mar 10, 2022 · 2 comments
Open

Deprecate Passthru parameter on Get-WebFile PowerShell helper #2640

AdmiringWorm opened this issue Mar 10, 2022 · 2 comments

Comments

@AdmiringWorm
Copy link
Member

AdmiringWorm commented Mar 10, 2022

Is Your Feature Request Related To A Problem? Please describe.

In version 0.9.10 the parameter Passthru was changed to a recommendation of not using it, and had been left due to backwards compatibility.
As this is recommended to not be used, we should deprecate its use and output a warning if it is used with a pending removal in the next major version.

Describe The Solution. Why is it needed?

It makes sense to deprecate anything that we do recommend to not be used, instead of purely leaving it as a comment.

Additional Context.

Link to DO NOT USE comment:

.PARAMETER PassThru
DO NOT USE - holdover from original function.

Related Issues

TODO: Add a link to an issue that will eventually remove this deprecation.

@gep13
Copy link
Member

gep13 commented Mar 12, 2022

We decided that this wasn't going out with 1.0.0, right? Should we assign to 1.1.0 so that it doesn't get lost?

@AdmiringWorm AdmiringWorm added this to the 1.1.0 milestone Mar 12, 2022
@AdmiringWorm
Copy link
Member Author

Yeah, we decided not to deprecate it in v1, I've changed the milestone to 1.1.0.

@pauby pauby modified the milestones: 1.1.0, 1.x Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants