Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chocolatey Licensed source without authentication stops Chocolatey from working #2736

Open
AdmiringWorm opened this issue Jun 10, 2022 · 2 comments

Comments

@AdmiringWorm
Copy link
Member

AdmiringWorm commented Jun 10, 2022

What You Are Seeing?

When running choco source add on the chocolatey.licensed source to for instance change it to allow self service. If you do so without adding a user and password switch to your command, Chocolatey CLI cannot be used after that.
What is Expected?

When authentication is not provided for the chocolatey.licensed source a 403 error would be desirable letting the user know of the error made.
How Did You Get This To Happen? (Steps to Reproduce)

Attempt to alter the chocolatey.licensed source via the following command choco source add --name="chocolatey.licensed" --source="https://licensedpackages.chocolatey.org/api/v2/" --allow-self-service
Then try running any Chocolatey CLI command, for instance choco
You get the following error output in shell: Value cannot be null. Parameter name: s

Output Log

N/A

Related issues

Followup from: chocolatey/chocolatey-licensed-issues#279

@vexx32
Copy link
Member

vexx32 commented Jun 10, 2022

Since this isn't a source users are expected to be fully setting up it might also be worth preventing users from modifying the user/password for this source (and maybe the url?) specifically and just letting them set the other configuration information. Maybe we just completely skip the setting of user/password when that source is updated by a user?

@pauby pauby changed the title Chocolatey Licensed source without authentication bricks Chocolatey Chocolatey Licensed source without authentication stops Chocolatey from working Jun 10, 2022
@AdmiringWorm
Copy link
Member Author

@vexx32 something similar to that is already being worked on the licensed side, but instead of denying the users to modify the items it instead sets the values if they haven't already been set (either by reusing the previously configured values or with the hard-coded values we already know about).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants