Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requestData() to MediaRecorder #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tscritch
Copy link

Closes #679

Simple passthrough like the other MediaRecorder functions.

If there's any reason to not do this or anything you'd like me to add let me know!

@chrisguttandin
Copy link
Owner

Hi @tscritch, thanks for your contribution.

Unfortunately it won't work before some other things get done. The native MediaRecorder already supports requestData() but the WebmPcmMediaRecorder and WebAudioMediaRecorder do not. Implementing it for the custom recorders is a little tricky because the custom encoder interface doesn't yet support it either.

@tscritch
Copy link
Author

tscritch commented Apr 17, 2024

@chrisguttandin ah I see. I figured that might be the case since it wasn't there already!

I'm trying to use this with katspaugh/wavesurfer.js which uses that to render the waveforms while recording. which uses that to ensure data gets captured after a pause in the recording. Not sure if there's a way around it.

I'd still be up for taking a swing if it's not too crazy since other people are interested in this being solved.
I can take a deeper look in the next week. If you have any ideas on approach I'd love your expertise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .requestData()
2 participants