New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is buf global variable? #14

Open

Ciruman opened this issue Oct 15, 2018 · 2 comments

Contributor

Ciruman commented Oct 15, 2018

Hi Chris,

I saw this variable is only here used. Why is "buf" a global variable?

Thanks,
Diego

DemoFX/src/main/java/com/chrisnewland/demofx/effect/video/VideoStream.java

Line 80 in 0e8b9f3

buf = player.impl_getLatestFrame();

Contributor Author

Ciruman commented Oct 15, 2018

I have a demofx javafx 11 version and I saw this and I do not know the reason.

Owner

chriswhocodes commented Oct 15, 2018

I probably had an accessor method for it at one point but then removed it. Looks like it can be safely turned into a local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment