Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix silent volume resize failure #44

Closed
rytswd opened this issue Jan 30, 2025 · 0 comments · Fixed by #46
Closed

Fix silent volume resize failure #44

rytswd opened this issue Jan 30, 2025 · 0 comments · Fixed by #46
Assignees
@Praveen005

Comments

@rytswd
Copy link
Member

rytswd commented Jan 30, 2025

civo-csi/pkg/driver/controller_server.go

Line 447 in 69860a8

d.CivoClient.ResizeVolume(volID, int(desiredSize))

With this code, the return value and error are thrown away, and we cannot find how the resize is failing from the CSI POV.

We should have a clear error message and early return, and also test cases to cover both successful and failure cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Praveen005 Praveen005

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix silent volume resize failures and add unit tests for ControllerExpandVolume method civo/civo-csi
2 participants
@rytswd @Praveen005