Add XLoader image to run in it's own container, separate from the CKAN UI container #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile, Makefile and setup process
kowh-ai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
This PR attempts to create an XLoader image to be used as a replacement for DataPusher.
However it currently has a problem in that the callback to the ckan container uses the resource data URL. This means if the URL is something like
http://localhost:5000/dataset/testset20/resource/26004e4f-d13c-49f3-b370-bc38806050faXLoader will try to connect to the ckan container running on localhost:5000 which is the xloader container rather than the ckan containerThere needs to be a modification to the XLoader extension itself to allow similar environment variable to DataPusher ie:
ckan.datapusher.callback_url_base. This would allow control of over what URL xloader would use to communicate back to the ckan containerIt seems these are currently the only xloader configuration parameters available:
ckanext.xloader.jobs_db.urickanext.xloader.api_tokenckanext.xloader.formatsckanext.xloader.max_content_lengthckanext.xloader.use_type_guessingckanext.xloader.strict_type_guessingckanext.xloader.max_type_guessing_lengthckanext.xloader.parse_dates_dayfirstckanext.xloader.parse_dates_yearfirstckanext.xloader.job_timeoutckanext.xloader.ignore_hashckanext.xloader.max_excerpt_linesckanext.xloader.ssl_verifyckanext.xloader.clean_datastore_tables