Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported links that are then edited are sent to AP Outbox with escaped characters #167

Open
jeffsikes opened this issue Nov 4, 2023 · 0 comments

Comments

@jeffsikes
Copy link
Contributor

I imported a bunch of links today through the admin tool, and all worked as expected. They were imported, the system attempted to grab opengraph titles and descriptions. The entries were not federated, as expected.

However, later this evening I went back to edit them, and add tags. I wasn't expecting them to get federated since they didn't when first entered, but they did. (Should they?)

When postmarks imports opengraph data, it surrounds the description in quotes.

When the postmark entry is edited and prepared for delivery to the AP outbox, a line break is added between the linked title and the description, which is in quotes. Both the line break and the quotes get escaped and then display inaccurately in client apps.

So there are two issues to address:

  • Should imported items that get edited end up pushed to the AP outbox?
  • Correctly dealing with the line break and quotes included in imported bookmarks.
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant