Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][trino-python-client] add new trino python client && support trino set session. #3831

Closed

Conversation

zhuzhengjun01
Copy link

What changes were proposed in this pull request?

Added a new trino python client to support the execution of commands such as trino set sessions through the python client

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
    it is test by manual tests, however,this code if forked from hue , and most of the code come from hue original

Copy link
Collaborator

@amitsrivastava amitsrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhuzhengjun01 thanks for the contribution. Can you explain the need for a new trino client, given that a trino client was recently added to Hue?

~ Outdated
@@ -0,0 +1,30 @@
pick 8e73ecf23f [feature][trino-python-client] add new trino python client && support trino set session
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file came by a mistake. Please check.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file came by a mistake. Please check.

Sry I will remove this file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has been removed, may caused by git rebase

@zhuzhengjun01
Copy link
Author

@zhuzhengjun01 thanks for the contribution. Can you explain the need for a new trino client, given that a trino client was recently added to Hue?

@zhuzhengjun01 thanks for the contribution. Can you explain the need for a new trino client, given that a trino client was recently added to Hue?

Thanks for your reply~
The original trino connector does not support set session and multi-sql execution. In addition, if you connect trino through jdbc, there will be a memory leak problem. In order to solve this problem, it was changed to python client, which is different from the original one.

issue: #3223

@zhuzhengjun01 zhuzhengjun01 force-pushed the feature/new-trino-python branch from bb2ccfc to 2d3a5a2 Compare September 12, 2024 08:49
@zhuzhengjun01 zhuzhengjun01 force-pushed the feature/new-trino-python branch from 28a86cc to f633a4a Compare September 12, 2024 08:55
Copy link

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 28, 2024
@github-actions github-actions bot closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants