[ui-storagebrowser] moves the HDFS config to /fileSystem API #3987
Conversation
…configs in its response
ramprasadagarwal
requested review from
nidhibhatg,
tabraiz12,
JohanAhlen and
bjornalm
| const urlPathname = window.location.pathname; | ||
| const urlSearchParams = new URLSearchParams(window.location.search); | ||
| const urlFilePath = decodeURIComponent(urlSearchParams.get('path') ?? ''); | ||
| const { fileSystem: urlFileSystem } = getFileSystemAndPath(urlFilePath); | ||
| const initialFilePath = urlFileSystem === fileSystem ? urlFilePath : homeDir; | ||
| const initialFilePath = | ||
| urlFileSystem === fileSystem.file_system ? urlFilePath : fileSystem.user_home_directory; |
There was a problem hiding this comment.
I think there is a naming problem here: fileSystem.file_system
I would also like to avoid snake_case in the UI. We use cameCase in all naming so we should try and stick to that. Sometimes we get properties from the backend that uses snake_case but it is a simple tasks to rename them before passing them a along to the rest of the UI code.
| groups?: ListDirectory['groups']; | ||
| isFsSuperUser?: ListDirectory['is_fs_superuser']; | ||
| isTrashEnabled?: boolean; | ||
| config: FileSystem['config']; |
There was a problem hiding this comment.
So we expect that the input of StorageBrowserRowActionsProps will stay aligned with whatever we define FileSystem['config'] as? I'm asking because if we expect that FileSystem['config'] might evolve into a superset of what we actually need here then this will not add much value.
| @@ -124,7 +113,7 @@ const StorageBrowserActions = ({ | |||
| }; | |||
|
|
|||
| const actionItems: MenuItemType[] = useMemo(() => { | |||
| const enabledActions = getEnabledActions(t, selectedFiles, isFsSuperUser); | |||
| const enabledActions = getEnabledActions(t, selectedFiles, config?.is_hdfs_superuser); | |||
There was a problem hiding this comment.
Is there a case where we are going to show action modals like the DeletionModal without ever getting the config?
If the config is just arriving during a later rendering cycle then should we even show those related modals before we have the config?
There was a problem hiding this comment.
This won't be a case, we get this config from the /fileSystem API which is the first and foremost call made in the storage-browser. After getting the response we make subsequent calls and show the action buttons on list directory page.
| label: string; | ||
| key: number; | ||
| icon: React.ReactNode; | ||
| user_home_dir: string; |
What changes were proposed in this pull request?
/list_dirAPI to/filesystemAPI.How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.