[api] Refactor /move API with additional validation checks #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshg999
requested review from
wing2fly,
amitsrivastava,
tabraiz12,
JohanAhlen,
bjornalm,
ramprasadagarwal,
ranade1,
athithyaaselvam,
agl29 and
nidhibhatg
Harshg999
changed the title
JohanAhlen
approved these changes
Feb 11, 2025
|
|
||
| # Check if destination path is parent of source path | ||
| if _is_destination_parent_of_source(request, source_path, destination_path): | ||
| return HttpResponse('Destination cannot be the parent directory of source.', status=400) |
There was a problem hiding this comment.
Is this not the same as identical paths above? I take it it's different for folders but the message could be the same "Source and destination must be different"
There was a problem hiding this comment.
Somehow I feel from API perspective, the original error message makes sense here and clearly explains the issue.
Assume you are hitting the API with source and destination path which are different but still you get the message that Source and destination must be different which feels vague and will require extra effort to figure out that the parent path cannot be same because that'd make move operation in same directory.
What do you think?
tabraiz12
reviewed
Feb 11, 2025
tabraiz12
approved these changes
Feb 11, 2025
Harshg999
force-pushed
the
improve-move
branch
from
48e5adc to
8e473d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?