Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Improve content disposition handling in /download API #3994

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

Harshg999
Copy link
Collaborator

What changes were proposed in this pull request?

  • This changes fixes the filename issue when downloading the file from new storage browser. Now the file gets downloaded with correct filename instead of "download"."extension" such as download.csv, download.txt etc.

How was this patch tested?

  • Manually

Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Harshg999 Harshg999 enabled auto-merge (squash) February 12, 2025 14:40
@Harshg999 Harshg999 merged commit dae2070 into master Feb 12, 2025
5 of 6 checks passed
@Harshg999 Harshg999 deleted the fix-download-name branch February 12, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants