Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Change RESTRICT_FILE_EXTENSIONS config's default value and fix restricted types handling in /rename API #3995

Merged
merged 3 commits into from
Feb 11, 2025
Merged

[api] Change RESTRICT_FILE_EXTENSIONS config's default value and fix restricted types handling in /rename API #3995

merged 3 commits into from
Feb 11, 2025

Conversation

Harshg999
Copy link
Collaborator

@Harshg999 Harshg999 commented Feb 11, 2025 •
edited
Loading

What changes were proposed in this pull request?

  • Fixes the issue where rename fails when the config is not set and files with no extensions were not allowed to rename in new storage browser.
  • It also fixes upload operation for both new storage browser and old filebrowser where uploads of file with no extensions were failing when the config was not set.

How was this patch tested?

  • Manually
  • Unit tests

@Harshg999 Harshg999 enabled auto-merge (rebase) February 11, 2025 15:13
@Harshg999 Harshg999 assigned Harshg999 and unassigned Harshg999 Feb 11, 2025
@Harshg999 Harshg999 merged commit d2ac71a into master Feb 11, 2025
6 checks passed
@Harshg999 Harshg999 deleted the fix-rename-restrict branch February 11, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabraiz12 tabraiz12 tabraiz12 approved these changes

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@wing2fly wing2fly Awaiting requested review from wing2fly

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@bjornalm bjornalm Awaiting requested review from bjornalm

@ramprasadagarwal ramprasadagarwal Awaiting requested review from ramprasadagarwal

@ranade1 ranade1 Awaiting requested review from ranade1

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

@agl29 agl29 Awaiting requested review from agl29

@nidhibhatg nidhibhatg Awaiting requested review from nidhibhatg

Assignees

@Harshg999 Harshg999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harshg999 @tabraiz12 @JohanAhlen