Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPCP-13540 DW New parameter: enable_private_eks #203

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Feb 4, 2025

The enable_private_eks option is added to the AWS DW module. With this parameter the inverting proxy endpoint is set up and the EKS API endpoint will use a private address.

@tevesz tevesz requested a review from a team as a code owner February 4, 2025 04:47
Copy link

github-actions bot commented Feb 4, 2025

Go test coverage: 35.5% for commit 72fa8b6
⚠️ 2 of 17 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                                    | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                           |    14.3%
+ github.com/cloudera/terraform-provider-cdp/provider                             |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub                    |    35.8%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake                   |     9.2%
- github.com/cloudera/terraform-provider-cdp/resources/de                         |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws             |    71.9%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog         |    65.8%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/dataviz                 |    78.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/hive   |    77.7%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/impala |    70.2%
+ github.com/cloudera/terraform-provider-cdp/resources/environments               |    44.4%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                        |     2.7%
- github.com/cloudera/terraform-provider-cdp/resources/ml                         |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb                       |    25.4%
+ github.com/cloudera/terraform-provider-cdp/resources/recipe                     |    12.0%
+ github.com/cloudera/terraform-provider-cdp/utils                                |    56.1%
+ github.com/cloudera/terraform-provider-cdp/utils/test                           |    75.0%

prateek1192
prateek1192 previously approved these changes Feb 5, 2025
Copy link
Contributor

@prateek1192 prateek1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vcsomor
vcsomor previously approved these changes Feb 7, 2025
@gregito
Copy link
Contributor

gregito commented Feb 12, 2025

@tevesz what is the status on this?

@tevesz tevesz force-pushed the CDPCP-13540 branch 3 times, most recently from 78dc699 to bbdf293 Compare February 13, 2025 17:02
gregito
gregito previously approved these changes Feb 17, 2025
The enable_private_eks option is added to the AWS DW module. With this
parameter the inverting proxy endpoint is set up and the EKS API
endpoint will use a private address.
@tevesz tevesz merged commit 7eee900 into main Feb 17, 2025
14 checks passed
@gregito gregito deleted the CDPCP-13540 branch February 17, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants