Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix end to end dw cluster test runs #210

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix end to end dw cluster test runs #210

merged 1 commit into from
Feb 14, 2025

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Feb 13, 2025 •
edited
Loading

Clusters are auto-deleted from the AWS account. To keep them some tags with the proper values must be applied.
This change removes the owner tag, the framework value should be used automatically to keep the resources around.

@tevesz tevesz requested a review from a team as a code owner February 13, 2025 22:10
@tevesz tevesz enabled auto-merge (squash) February 13, 2025 22:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Go test coverage: 35.5% for commit 1a9a77d
⚠️ 2 of 17 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages 
# Package Name                                                                    | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                           |    14.3%
+ github.com/cloudera/terraform-provider-cdp/provider                             |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub                    |    35.8%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake                   |     9.2%
- github.com/cloudera/terraform-provider-cdp/resources/de                         |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws             |    71.9%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog         |    65.8%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/dataviz                 |    78.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/hive   |    77.7%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/impala |    70.2%
+ github.com/cloudera/terraform-provider-cdp/resources/environments               |    44.4%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                        |     2.7%
- github.com/cloudera/terraform-provider-cdp/resources/ml                         |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb                       |    25.4%
+ github.com/cloudera/terraform-provider-cdp/resources/recipe                     |    12.0%
+ github.com/cloudera/terraform-provider-cdp/utils                                |    56.1%
+ github.com/cloudera/terraform-provider-cdp/utils/test                           |    75.0%

@tevesz tevesz force-pushed the fix-e2e-dw branch 2 times, most recently from 2e15e38 to 8c4d359 Compare February 14, 2025 00:15
@tevesz
Fix end to end dw cluster test runs
1c74e64 
Clusters are auto-deleted from the AWS account. To keep them some tags
with the proper values must be applied.
This change removes the owner tag, the frameword value should be used
automatically to keep the resources around.
@tevesz tevesz merged commit b162f8c into main Feb 14, 2025
14 checks passed
@gregito gregito deleted the fix-e2e-dw branch February 14, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek1192 prateek1192 prateek1192 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tevesz @prateek1192