Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset ssh_session_log in cloudflare_teams_account resource spurs perpetual diff #3897

Open
3 tasks done
ChefAustin opened this issue Sep 4, 2024 · 5 comments
Open
3 tasks done
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@ChefAustin
Copy link

ChefAustin commented Sep 4, 2024

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

- Installing cloudflare/cloudflare v4.30.0...
- Installed cloudflare/cloudflare v4.30.0 (self-signed, key ID C76001609EE3B136)
- Installing hashicorp/random v3.1.0...
- Installed hashicorp/random v3.1.0 (signed by HashiCorp)

Affected resource(s)

cloudflare_teams_account

Terraform configuration files

resource "cloudflare_teams_account" "default" {
  account_id                 = var.account_id
  activity_log_enabled       = true
  protocol_detection_enabled = true

  block_page {
    enabled          =  true
    name             = "Redacted"
    footer_text      =  var.block_page.default.footer
    header_text      =  var.block_page.default.header
    logo_path        = "https://redacted.redacted.com/redacted/redacted.svg"
    background_color = "#ffffff"
  }

  extended_email_matching {
    enabled = false
  }

  logging {
    redact_pii = true

    settings_by_rule_type {
      dns {
        log_all    = true
        log_blocks = true
      }
      http {
        log_all    = true
        log_blocks = true
      }
      l4 {
        log_all    = true
        log_blocks = true
      }
    }
  }

  proxy {
    tcp     = true
    udp     = true
    root_ca = true
  }

  tls_decrypt_enabled = false
}

Link to debug output

https://gist.github.com

Panic output

No response

Expected output

When ssh_session_log is unset (as it is not required), I expected no changes to be spurred.

Actual output

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.warp.cloudflare_teams_account.default will be updated in-place
  ~ resource "cloudflare_teams_account" "default" {
        id                                     = "redacted"
        # (6 unchanged attributes hidden)

      - ssh_session_log {}

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Steps to reproduce

See further details in #2996

Additional factoids

No response

References

This is a duplicate of a now-closed issue (#2996)

@ChefAustin ChefAustin added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ChefAustin ChefAustin changed the title Unset ssh_session_log in cloudflare_teams_account's spurs perpetual diff Unset ssh_session_log in cloudflare_teams_account resource spurs perpetual diff Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Marking this issue as stale due to 30 days of inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@ChefAustin
Copy link
Author

Can someone from Cloudflare weigh-in, here?

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Marking this issue as stale due to 30 days of inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

1 participant