You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
service AWS {
option (temporal.v1.service) = {task_queue: 'aws-task-queue'};
// ManageAWS does some workflow thing.
rpc ManageAWS(ManageAWSRequest) returns (ManageAWSResponse) {
option (temporal.v1.workflow) = {id: 'some-workflow-1/${! id }/${! uuid_v4() }'};
}
// ManageAWSResource does some workflow thing.
rpc ManageAWSResource(ManageAWSResourceRequest) returns (ManageAWSResourceResponse) {
option (temporal.v1.workflow) = {id: 'some-workflow-2/${! uuid_v4() }'};
}
}
The generated output for the service name and the methods get confused around the casing here. It will generate methods such as ManageAwsasync (note the async part is all lower case). The issue as far as I understand comes from how github.com/iancoleman/strcase is used. This tool will dump ManageAWSAsync into this and that library sees AWSA and assumes that is one word.
This problem seems to come around v1.3.0 of this tool which I understand is quite old at this point. I've been updating our libraries and so our older code generated output with initialism but now we get the above problem. The naming changes will force us into migrating our workflows since Temporal will not see them as the same. So I'm hoping that I can avoid this by keeping the initialism. This is also more consistent with other generated output such protoc-gen-go itself and other tools such as the generators for gRPC and ConnectRPC.
The strcase library has methods to provide initialisms. Would you be open to allowing this plugin to pass through some data as a flag? I've opened #89 and #91 to demonstrate what I'm seeing with and without a flag to mask the output.
The text was updated successfully, but these errors were encountered:
Consider a protobuf service such as this:
The generated output for the service name and the methods get confused around the casing here. It will generate methods such as
ManageAwsasync
(note theasync
part is all lower case). The issue as far as I understand comes from howgithub.com/iancoleman/strcase
is used. This tool will dumpManageAWSAsync
into this and that library seesAWSA
and assumes that is one word.This problem seems to come around v1.3.0 of this tool which I understand is quite old at this point. I've been updating our libraries and so our older code generated output with initialism but now we get the above problem. The naming changes will force us into migrating our workflows since Temporal will not see them as the same. So I'm hoping that I can avoid this by keeping the initialism. This is also more consistent with other generated output such protoc-gen-go itself and other tools such as the generators for gRPC and ConnectRPC.
The
strcase
library has methods to provide initialisms. Would you be open to allowing this plugin to pass through some data as a flag? I've opened #89 and #91 to demonstrate what I'm seeing with and without a flag to mask the output.The text was updated successfully, but these errors were encountered: