Feat: Extend resource_wait_for_uninstall
#18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
svteb
force-pushed
the
wait_for_pods
branch
2 times, most recently
from
97190bf to
3113035
Compare
Refs: #2194 - Change allows for a deep check that will verify if associated resources (pods) of some core resource were deleted. - In some cases a pod finalizer may be stuck which would force the user to manually cancel cnf_uninstall and not be informed of what is happening. - Changes to the delete module were warranted since --wait=true flag is set by default, thus this parameter never affected anything. The change is also necessary since the waiting will be done through resource_wait_for_uninstall instead (the default value will be false). Signed-off-by: svteb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
resource_wait_for_uninstallfunction is to be used in a pull request that will resolve #2194, but in its previous state it did not check that the associated resources (pods) were properly deleted. In some scenarios, such as a pod being stuck due to a finalizer, the function would not detect anything.Related testsuite pull request: #XXXX
Pull request is currently based on #17 and will need to be rebased after #17 is merged.
Issues:
Refs: #2194
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue