Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitmate_gitlab.md Fix link, correct typos #225

Closed
wants to merge 2 commits into from
Closed

gitmate_gitlab.md Fix link, correct typos #225

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2017

Fix: broken link for Bitbucket, correct various typos

Fixes: #224

Fix: broken link for Bitbucket, correct various typos

Fixes: #224
@sahilarora535
Copy link

The commit message and shortlog needs revision. Please go through this guide.

gitmate_gitlab.md: Fix link, typos, reword

Correct broken link, typos, reword

Fixes #224
@ghost
Copy link
Author

ghost commented Feb 17, 2017

I believe the errors in the commit message were resolved

@Sanny26
Copy link
Member

Sanny26 commented Feb 17, 2017

@Razoic The issue is to correct typos and broken link. Could I know why your PR has a description of the project? Seems like you have copied the file and created a new one..is it meant to be in the PR?

@ghost
Copy link
Author

ghost commented Feb 17, 2017

I was attempting to replace the commit comments with the update. I was using Desktop Github, which I've since been advised not too. I am interested in trying to participate however the added complexity of trying to do so in a Windows environment via Bash on Ubuntu on Windows, added to my confusion. If you could please rollback this to its preassigned state (keeping the issue open) I'ld appreciate it. I'm relearning the process on a Ubuntu vbox, and git management, with a smaller project, I hope to rejoin when able.

@Sanny26
Copy link
Member

Sanny26 commented Feb 17, 2017

@Razoic I'm a newcomer as well. I too took a lot of time to understand git and submit a PR without doing any errors. If you are talking about withdrawing from this issue, I think you should give it a try once again.
I think you can use git reset to remove your last commit (not sure, though)
Use this link: https://api.coala.io/en/latest/Developers/Git_Basics.html .I find the link very helpful whenever I do a mistake.

@ghost
Copy link
Author

ghost commented Feb 17, 2017

As I understand it, you are reviewing this PR, and not approving it. I do not understand your comment on what needs to changed. The only test it is failing is your review. Please revert this issue to it's previous state,

@Sanny26
Copy link
Member

Sanny26 commented Feb 18, 2017

You have two commits on your PR. First one fixes the issue, and the second one adds a new file, right? All I'm asking is why do you have this file? It doesn't seem to be related to the issue.

@ghost
Copy link
Author

ghost commented Feb 18, 2017

Please refer to the comments above.

  1. I made a pull request that contained the first commit to 'Razoic: raz-projects-2'.
  2. sahilarora535 reviewed my commit (review/gitmate/manual )
    • he advised the commit comments were not in the correct style
  3. following the instructions in the guide, I made a new commit to the branch ' Razoic: raz-projects-2'. with an updated commit message.
  4. Sanny26 reviewed, This is the point in the process I no longer understand what is wrong with the pull request as is, I spend a number of hours researching why it would not pass review, failing to find a reason, I requested you rollback this issue to it's original status, as I am not certain of the process to do so without closing the issue, as I have left the project until I have a better grasp on git workflow and requirements.

@Sanny26
Copy link
Member

Sanny26 commented Feb 18, 2017

Please look at https://github.com/coala/projects/pull/225/files
The first commit you did on your branch made the necessary changes required for the issue.
After sahilarora535 reviewed the commit, you were asked to make changes to your commit message. Along with the changes to the message, you have uploaded an additional file to the branch, which is not relevant to the issue. All I am asking for you is to remove this additional file.
Is this understandable?

@ghost ghost closed this Feb 18, 2017
@ghost ghost reopened this Feb 18, 2017
@ghost ghost closed this Feb 18, 2017
@ghost ghost deleted the raz-projects-2 branch February 18, 2017 15:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants