Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findDOMNode is deprecated in StrictMode #20

Open
jroboyd opened this issue Apr 9, 2021 · 1 comment
Open

findDOMNode is deprecated in StrictMode #20

jroboyd opened this issue Apr 9, 2021 · 1 comment

Comments

@jroboyd
Copy link

jroboyd commented Apr 9, 2021

Hi I like the component, getting this warning however:

Warning: findDOMNode is deprecated in StrictMode

I think they want you to use refs, I see in the code you have marked is a difficult issue, I think it might be possible using this method:

https://stackoverflow.com/questions/29568721/getting-dom-node-from-react-child-element

@webholics
Copy link
Contributor

Hi, thank you for your interest in this library.

We are aware that in principle this is solvable with React refs. However this would require all childs of the positioning portal to also forward the ref to the appropriate DOM element which would be quite a breaking change. Also we don't want to inject an additional <div /> as a wrapper because this brings opinion into styling.

For now we didn't find a good solution to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants