-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy parsing #158
Labels
Comments
It also would help with the performance problems I have when manipulating iCalendar files in a way that doesn't involve properties at all. E.g. in vdirsyncer I had to write my own parser, both due to performance and tolerance of broken items. |
+1, sounds like a good enhancement. |
stlaz
added a commit
to stlaz/icalendar
that referenced
this issue
Aug 12, 2016
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of collective#158 Improves collective#174
stlaz
added a commit
to stlaz/icalendar
that referenced
this issue
Aug 12, 2016
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of collective#158 Improves collective#174
stlaz
added a commit
to stlaz/icalendar
that referenced
this issue
Sep 8, 2016
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of collective#158 Improves collective#174
stlaz
added a commit
to stlaz/icalendar
that referenced
this issue
Sep 13, 2016
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of collective#158 Improves collective#174
stlaz
added a commit
to stlaz/icalendar
that referenced
this issue
Jul 20, 2017
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of collective#158 Improves collective#174
thet
pushed a commit
that referenced
this issue
Oct 13, 2021
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of #158 Improves #174
thet
pushed a commit
that referenced
this issue
Oct 15, 2021
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of #158 Improves #174
thet
pushed a commit
that referenced
this issue
Oct 15, 2021
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of #158 Improves #174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Icalendar currently raises exceptions on minor things like invalid datetimes as described in #155. I think iCalendar could parse property values lazily, i.e. when
Component.__getitem__
is called, since some broken properties shouldn't stop the user from accessing the rest.The text was updated successfully, but these errors were encountered: