From 3d9bf7134959c28b75576a4e7c7dc52dff4b3ed9 Mon Sep 17 00:00:00 2001
From: Chris Norman <17420369+chrnorm@users.noreply.github.com>
Date: Wed, 9 Oct 2024 17:18:17 -0700
Subject: [PATCH] tidy unused packages and variables (#773)

removes some stale build variables and unused variables
---
 internal/build/urls.go    |  6 ------
 pkg/assume/entrypoint.go  |  1 -
 pkg/banners/banners.go    | 11 -----------
 pkg/granted/entrypoint.go |  1 -
 4 files changed, 19 deletions(-)
 delete mode 100644 internal/build/urls.go
 delete mode 100644 pkg/banners/banners.go

diff --git a/internal/build/urls.go b/internal/build/urls.go
deleted file mode 100644
index 15baffb0..00000000
--- a/internal/build/urls.go
+++ /dev/null
@@ -1,6 +0,0 @@
-package build
-
-// these URLs are overridden as part of the release build process.
-var (
-	UpdateCheckerApiUrl = "localhost:10002"
-)
diff --git a/pkg/assume/entrypoint.go b/pkg/assume/entrypoint.go
index 59a5b34e..a3c7cbf9 100644
--- a/pkg/assume/entrypoint.go
+++ b/pkg/assume/entrypoint.go
@@ -37,7 +37,6 @@ func GlobalFlags() []cli.Flag {
 		&cli.StringSliceFlag{Name: "pass-through", Aliases: []string{"pt"}, Usage: "Pass args to proxy assumer"},
 		&cli.BoolFlag{Name: "active-role", Aliases: []string{"ar"}, Usage: "Open console using active role"},
 		&cli.BoolFlag{Name: "verbose", Usage: "Log debug messages"},
-		&cli.StringFlag{Name: "update-checker-api-url", Value: build.UpdateCheckerApiUrl, EnvVars: []string{"UPDATE_CHECKER_API_URL"}, Hidden: true},
 		&cli.StringFlag{Name: "active-aws-profile", EnvVars: []string{"AWS_PROFILE"}, Hidden: true},
 		&cli.BoolFlag{Name: "auto-configure-shell", Usage: "Configure shell alias without prompts"},
 		&cli.StringFlag{Name: "exec", Usage: "Assume a profile then execute this command"},
diff --git a/pkg/banners/banners.go b/pkg/banners/banners.go
deleted file mode 100644
index bb6fa7ed..00000000
--- a/pkg/banners/banners.go
+++ /dev/null
@@ -1,11 +0,0 @@
-package banners
-
-import (
-	"fmt"
-
-	"github.com/common-fate/granted/internal/build"
-)
-
-func WithVersion() string {
-	return fmt.Sprintf("Granted version: %s\n", build.Version)
-}
diff --git a/pkg/granted/entrypoint.go b/pkg/granted/entrypoint.go
index 979915a6..e2bc9c09 100644
--- a/pkg/granted/entrypoint.go
+++ b/pkg/granted/entrypoint.go
@@ -34,7 +34,6 @@ func GetCliApp() *cli.App {
 
 	flags := []cli.Flag{
 		&cli.BoolFlag{Name: "verbose", Usage: "Log debug messages"},
-		&cli.StringFlag{Name: "update-checker-api-url", Value: build.UpdateCheckerApiUrl, EnvVars: []string{"UPDATE_CHECKER_API_URL"}, Hidden: true},
 		&cli.StringFlag{Name: "aws-config-file"},
 	}