[package]poco/1.13.3 Extend system_libs with mswsock for poco_net component, when building with MinGW #26419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@lbakman Thank you again for providing this PR, plus, adding your build logs! This is a high-quality PR!! I just started the CI to build your PR now, I'll review it as soon as we have the build result. Regards! |
uilianries
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
LGTM. Approved based on my previous comment: #26404 (comment)
The MinGW and Cygwin should both work with mswsock, so Windows + GCC should be enough for this specific case.
Thank you for your PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: poco/1.13.3
Motivation
Fixes #26404
Details
Added
_is_mingwproperty.Modified
package_infoto extendsystem_libswithmswsockfor thepoco_netcomponent when building with MinGW.This happens when building poco as a static library, when
enable_netis set to True and when the version of poco is >= 1.13.0.output_before_patch.txt: Build output before applying change.
output_after_patch.txt: Build output after applying change.