Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error reporting for common cases #59

Open
allisonkarlitskaya opened this issue Jan 17, 2025 · 1 comment · May be fixed by #68
Open

Add better error reporting for common cases #59

allisonkarlitskaya opened this issue Jan 17, 2025 · 1 comment · May be fixed by #68

Comments

@allisonkarlitskaya
Copy link
Collaborator

We have a few people trying out the examples lately and they tend to run into a couple of common issues for which we have terrible error messages:

  • can't enable fs-verity because the FS doesn't support it
  • skopeo isn't installed

The first one is 100% on us: we need a better error for that. The second one is arguably something to be fixed in containers-image-proxy-rs.

See also #25

mvo5 added a commit to mvo5/containers-image-proxy-rs that referenced this issue Jan 17, 2025
This commit adds a new SkopeoSpawnError that helps with tweaking
the user-experience when e.g. skopeo is not installed.

Partially closes:
containers/composefs-rs#59

Signed-off-by: Michael Vogt <[email protected]>
mvo5 added a commit to mvo5/containers-image-proxy-rs that referenced this issue Jan 17, 2025
This commit adds a new SkopeoSpawnError that helps with tweaking
the user-experience when e.g. skopeo is not installed.

Partially closes:
containers/composefs-rs#59

Signed-off-by: Michael Vogt <[email protected]>
@allisonkarlitskaya
Copy link
Collaborator Author

Silly github closed this automatically...

mvo5 added a commit to mvo5/composefs-rs that referenced this issue Feb 14, 2025
This commit improves the UX of the error reporting when enabling
fs-verity fails because the underlying filesystem does not support
this. Here we currently just error with:
```
Inappropriate ioctl for device"
```
with the new code we error with:
```
Filesystem not supported by fs-verity
```

Note that the test relies on the fact that /dev/shm is not supported
by fs-verity.

Closes: containers#59
mvo5 added a commit to mvo5/composefs-rs that referenced this issue Feb 14, 2025
This commit improves the UX of the error reporting when enabling
fs-verity fails because the underlying filesystem does not support
this. Here we currently just error with:
```
Inappropriate ioctl for device"
```
with the new code we error with:
```
Filesystem not supported by fs-verity
```

Note that the test relies on the fact that /dev/shm is not supported
by fs-verity.

Closes: containers#59
mvo5 added a commit to mvo5/composefs-rs that referenced this issue Feb 17, 2025
This commit improves the UX of the error reporting when enabling
fs-verity fails because the underlying filesystem does not support
this. Here we currently just error with:
```
Inappropriate ioctl for device"
```
with the new code we error with:
```
Filesystem not supported by fs-verity
```

Note that the test relies on the fact that /dev/shm is not supported
by fs-verity.

Closes: containers#59
Signed-off-by: Michael Vogt <[email protected]>
mvo5 added a commit to mvo5/composefs-rs that referenced this issue Feb 19, 2025
This commit improves the UX of the error reporting when enabling
fs-verity fails because the underlying filesystem does not support
this. Here we currently just error with:
```
Inappropriate ioctl for device"
```
with the new code we error with:
```
Filesystem not supported by fs-verity
```

Note that the test relies on the fact that /dev/shm is not supported
by fs-verity.

Closes: containers#59
Signed-off-by: Michael Vogt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant