Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up branch protection for this repo #86

Open
baude opened this issue Feb 11, 2025 · 1 comment
Open

Set up branch protection for this repo #86

baude opened this issue Feb 11, 2025 · 1 comment

Comments

@baude
Copy link
Member

baude commented Feb 11, 2025

We need to set up branch protection for this repo so things like #85 where I gave a /lgtm and it merged prior to completing tests does not happen.
@Luap99
Copy link
Member

Luap99 commented Feb 13, 2025

I did configure branch protection in the github settings just now. However at least from history the podman does not care about that and it has to be configured in the openshift config as well, although I would like to test if the github settings is enough before adding it there as I used a new ruleset there (compared to the old branch protection rules) and I would expect that is enforced even with the bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baude @Luap99