Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure linting always applied #825

Open
mkesper opened this issue Feb 15, 2025 · 1 comment · May be fixed by #845
Open

Ensure linting always applied #825

mkesper opened this issue Feb 15, 2025 · 1 comment · May be fixed by #845

Comments

@mkesper
Copy link
Collaborator

mkesper commented Feb 15, 2025

It would be beneficial to enforce linting in CI so no commits are accepted where linting fails.
Every time you run make validate the linter will be run and automatically fix existing code, leading to bigger diffs of code than wanted.
@ericcurtin
Copy link
Collaborator

It was this way before, it has been removed from CI somehow, would welcome a PR to bring it back in.

@Mr-Sunglasses Mr-Sunglasses linked a pull request Feb 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure linting always applied Mr-Sunglasses/ramalama
2 participants
@ericcurtin @mkesper