Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static GRUB config migration does not handle GRUB configs stored in ESP #857

Open
travier opened this issue Feb 18, 2025 · 2 comments
Open

Comments

@travier
Copy link
Member

travier commented Feb 18, 2025

On older Silverblue systems (installed from Silverblue 33 at least), the GRUB config is stored in the ESP instead of /boot.

The migration logic that we have right now is not enough, as it would have to look at this file as well, clean it up, and enable blscfg and maybe also make sure to add the info pointing GRUB to the boot partition to find the boot entries.

See: https://discussion.fedoraproject.org/t/sb42-updates-fail-on-system-with-512mb-boot-128mb-boot-efi/145041/14

And also: #856

@travier travier changed the title Static GRUB config migration does clean up GRUB configs stored in ESP Static GRUB config migration does not clean up GRUB configs stored in ESP Feb 18, 2025
@travier travier changed the title Static GRUB config migration does not clean up GRUB configs stored in ESP Static GRUB config migration does not handle GRUB configs stored in ESP Feb 18, 2025
@travier
Copy link
Member Author

travier commented Feb 19, 2025

It looks like blscfg should be enabled by past updates of this file, so we would only have to cleanup the old ostree entries.

@HuijingHei
Copy link
Member

Maybe my understanding is not correct, do we need to run grub2-mkconfig to regenerate the new grub.cfg, also enable blscfg as I see the GRUB_ENABLE_BLSCFG=false in /etc/default/grub? Is it necessary to migrate to the static grub config in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants