Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing_build_prereqs probably shouldn't consider files in "xt/{author,release}/*" #11

Open
kentfredric opened this issue Jan 8, 2013 · 6 comments
Labels

Comments

@kentfredric
Copy link

http://cpants.cpanauthors.org/dist/Net-Minecraft-Login/errors

Its nice it reports these, but these tests are never run during installation, so they're not a "build" prerequisite at all.

at best, these should be deemed "Develop" prerequisites , which my dist already declares most of: https://metacpan.org/source/KENTNL/Net-Minecraft-Login-0.001000/META.json#L31

@dolmen
Copy link
Member

dolmen commented Jan 18, 2013

👍, but this should be reported against Module::CPANTS::Analyse.

@kentfredric
Copy link
Author

Hm, I can't find the string "missing_build_prereqs" anywhere in MCA, so this bug isn't 1:1

@kentfredric
Copy link
Author

Incidentally, if this really is MCA's fault, then why does it never pose a problem to Test::Kwalitee, which all my dists use?

@kentfredric
Copy link
Author

@charsbar
Copy link
Contributor

Asked Rik (also the author of Module::Instal:AuthorTests) at QAH and was told all files in xt/ should be ignored, thus cpants/Module-CPANTS-Analyse@83e91b5

Will rerun the analyzer when everything is sorted.

@karenetheridge
Copy link

This should probably be filed in https://rt.cpan.org/Dist/Display.html?Queue=Module-CPANTS-Analyse, rather than in the queue for the website itself.

(however, it would be sensible for prereqs in xt/{author,release,smoke} to be listed as develop requires.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants