upstream this repo to RustCrypto

[Dustin-Ray]

The RustCrypto project is collecting many popular and widely-used elliptic curves into a central repository for ease of use and high maintainability. This issue is tracking the curves added so far. Is there any interest from this project in upstreaming the work done so far into RustCrypto?

[kevaundray]

Hey,

I am interested in upstreaming the work here into RustCrypto. What would the steps be to upstream it?

[tarcieri]

@kevaundray hey, on behalf of @RustCrypto that's great news!

We have algorithm-family based monorepos. Here is the one for elliptic curves: https://github.com/rustcrypto/elliptic-curves

I would suggest opening a PR which adds an ed448/ed448-goldilocks subdirectory containing the most recent commit of the code.

When it's merged we can get you access to the repo and work out ownership for the associated crates.

Hopefully we can also contribute trait implementations which would allow Ed448-Goldilocks to be used with algorithm implementations which are generic over elliptic curves.

[dkg]

It would be great to bring this under the @RustCrypto umbrella. Thanks for working on this.

[dignifiedquire]

@mikelodder7 I saw that you started a new fork (but issues aren't enabled, so pinging you here) would you be interested in moving that version into rustcrypto? I could help with setup, if you want

[mikelodder7]

I'd be happy to do that. where do we go from here?

[mikelodder7]

@tarcieri This is the rep. https://github.com/mikelodder7/Ed448-Goldilocks

[mikelodder7]

Do I do the same thing as I did for frodoKem

[dignifiedquire]

Generally, adding the impl as a new folder in https://github.com/RustCrypto/elliptic-curves in a PR would be the first step.
The big question to me is can we import the git history, which it seems according to https://www.simplicidade.org/notes/2009/04/21/merging-two-unrelated-repositories/ should be posssible

[mikelodder7]

I don't really care about the git history TBH. I'll PR with the latest commit from my fork.

[mikelodder7]

However, there is the issue of license. The current license is BSD-3 Clause I can change my commits to match RustCrypto, but we might have to get approval from the original owners to do the rest

[dignifiedquire]

We should probably keep the license as BSD-3, and change it once we get sign off from the original author(s).

[mikelodder7]

Hopefully we can also contribute trait implementations which would allow Ed448-Goldilocks to be used with algorithm implementations which are generic over elliptic curves.

My fork has already done this so it shouldn't be an issue.

[mikelodder7]

We should probably keep the license as BSD-3, and change it once we get sign off from the original author(s).

Consider this my sign off to change the license to APL 2.0/MIT

[dignifiedquire]

Looks like parts of the code come from https://github.com/dalek-cryptography/curve25519-dalek/ So we will need to at least add references to https://github.com/dalek-cryptography/curve25519-dalek/blob/main/curve25519-dalek/LICENSE as done in #37

[dignifiedquire]

Current authors according to git history, please let us know if you accept relicensing the code to MIT/Apache 2.0

• @divergentdave
• @conradoplg
• @stackinspector
• @anonion0
• @kevaundray

From the fork

•  @mikelodder7

[divergentdave]

I approve relicensing my contribution

[conradoplg]

I approve relicensing my contribution

[mikelodder7]

What should the name of the project be under RustCrypto? ed448 and ed448-goldilocks crates already exist

[tarcieri]

I would suggest using ed448-goldilocks. I believe @kevaundray suggested he might transfer the crate name to us?

(It would be good to get ed448 as well but for https://github.com/RustCrypto/signatures/tree/master/ed448)

[mikelodder7]

okay I'll set it to that then

[mikelodder7]

PR #1121

[kevaundray]

Hi, thank you so much for taking this off of my hand :)

[kevaundray]

I approve relicensing my contribution

[kevaundray]

Generally, adding the impl as a new folder in https://github.com/RustCrypto/elliptic-curves in a PR would be the first step. The big question to me is can we import the git history, which it seems according to https://www.simplicidade.org/notes/2009/04/21/merging-two-unrelated-repositories/ should be posssible

Maybe you can add the current authors as co-authors to the PR you are merging?

[kevaundray]

I would suggest using ed448-goldilocks. I believe @kevaundray suggested he might transfer the crate name to us?

(It would be good to get ed448 as well but for https://github.com/RustCrypto/signatures/tree/master/ed448)

Yep, happy to transfer the crate over

[kevaundray]

I would suggest using ed448-goldilocks. I believe @kevaundray suggested he might transfer the crate name to us?

(It would be good to get ed448 as well but for https://github.com/RustCrypto/signatures/tree/master/ed448)

Not sure if useful, but there is also https://github.com/crate-crypto/x448

[Dustin-Ray]

Congratulations on the upstream everyone, this is a great project and Im thrilled to see it merged with the larger RustCrypto ecosystem. Thanks for the work on this.

[stackinspector]

I approve relicensing my contribution