Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You need to select more coins!" when editing a "speed up" transaction #2377

Open
leon-costa opened this issue Sep 7, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@leon-costa
Copy link
Contributor

Describe the bug
The "Speed up" button allows to "Fully edit the transaction", which is great when there's no change output (#988), but it fails to create the new transaction. It's probably because the inputs of the original transaction are considered spent, and thus don't appear in the coin selection list.

To Reproduce
Steps to reproduce the behavior:

  1. Have an unconfirmed transaction in a wallet
  2. Click on 'Speed up'
  3. Enter the new fee rate
  4. Click on "Advanced" and "Fully edit the transaction"
  5. Notice the inputs of the original transaction don't appear in the coin selection table
  6. Click on "Create the unsigned transaction"
  7. It says "You need to select more coins!"

Expected behavior

  • Either the new transaction should be created with the new fee rate and the same inputs,
  • or the UI should allow the selection of the same inputs as in the replaced transaction

Desktop:

  • Where is your node running: local(internal)
  • Where is your specter running: binary
  • If you're running a binary, which OS: Linux
  • Browser: electron
  • Specter Version: tested on 2.0.0, 2.0.1, and 2.0.2pre6

Additional context
It seems the code checks if there's enough coins selected by looking at the selected rows whereas there's no row for the spent outputs. The internal selected-coins list may contain the right coins though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants