-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new sim_telarray metadata system #29
Comments
Hi @maxnoe before we start using this version I think we should make sure that we have no problems reading those files. While you did the changes in pyeventio, it can still happen that there is a clash between the ctapipe and pyeventio versions and we might end up with needing to make some changes in lstchain to make it compatible with the ctapipe version that is compatible with the updated pyeventio. It might all work out of the box, but well, better to check it. |
@jsitarek Since this only added new fields to the It's actually the opposite: since the metadata are added by default using the current sim_telarray we already need the latest pyeventio, otherwise we will get the same error that you got when trying to analyze the files. |
Hi @maxnoe |
I don't understand what you mean by this. What other changes in the meantime? |
I checked in detail. As far as I can see ctapipe needs eventio 1.5.0 - 2.0, lstchain actually requires >=1.5.1, which is basically the same since I do not see the release 1.5.0. After 1.5.1 there was also 1.5.2 and then 1.6.0 with your latest change. My worry was e.g. in 1.5.2. there could have been something added that is not compatible with the current ctapipe or lstchain, and before it was working because it can always downgrade to 1.5.1. This would not be possible if we require 1.6 version. But I see that my lst environment is actually using 1.5.2 version, and there are no more changes in 1.6 for the moment, so indeed it should be all fine, you can disregard my earlier comment. |
The current lstchain tests are already running with eventio 1.6. The CI (and anybody setting up an environment) will always get the newest compatible version. As said, we use (or at least try) semantic versioning, so any breaking change would have resulted in being 2.0, which would then be excluded by the ctapipe requirements. Of course, I could by accident make a breaking change without realizing it.. |
See also discussion here: cta-observatory/ctapipe#1853 |
With Prod6, the metadata system will be used and future versions of ctapipe will very likely start relying on some of the metadata information being available. This includes for example using the telescope metaparams Here is how the LST metadata looks like in a current (2022-06-30) prod6 example run:
|
In the latest experimental release sim_telarray allows adding metadata to the output files.
It allows both exporting the final configuration options per telescope but also setting custom user attributes.
This seems very handy.
E.g. adding this:
to
CTA-PROD5-LaPalma-baseline.cfg
you get this withread_simtel -s -h <file>
(support in pyeventio is on the way):The text was updated successfully, but these errors were encountered: