Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need extended null check on edu.mayo.cts2.framework.webapp.rest.controller.UpdateHandler#update method #36

Open
kevinpeterson opened this issue Jan 8, 2016 · 0 comments

Comments

@kevinpeterson
Copy link
Contributor

It is not sufficient for the 'group' to be the only thing checked here for null. If the resource comes in with an ChangeableElementGroup that is empty, that needs to be checked too:

ChangeableElementGroup group = resource.getChangeableElementGroup();
if(group == null){
   ...
}

Change to something like:

if(group == null || (group.getChangeDescription() == null && group.getStatus() == null)) {
    ...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant